👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335252: Reduce size of j.u.Formatter.Conversion#isValid

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 95fe05a: 8136895: Writer not closed with disk full error, file resource leaked
• f7492dd: 8312475: org.jline.util.PumpReader signed byte problem
• 4241313: 8354941: Build failure with glibc 2.42 due to uabs() name collision
• ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/01a62e385ef9852dac37acd3eb88a36665330275...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

This backport pull request has now been updated with issue from the original commit.

⚠️ @phohensee This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Webrevs

• 00: Full (d43c1f6e)

/approval request Clean backport to fix a regression resulting from JDK-8263038. No semantic change, test/jdk/java/util/Formatter tests pass.

@phohensee
8335252: The approval request has been created successfully.

Hi @phohensee
I'm not so sure we need such optimizations and minor changes in 17, which is a quite stable release.
Thanks.

Right, but it's a followup to a JDK 17 enhancement which caused a performance regression which we (Amazon) encountered in production and fixed in our internal distro. Thanks for the approval!

/integrate

Going to push as commit 37b9867.
Since your change was applied there have been 24 commits pushed to the master branch:

• 3ee1839: 8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks
• 95fe05a: 8136895: Writer not closed with disk full error, file resource leaked
• f7492dd: 8312475: org.jline.util.PumpReader signed byte problem
• ... and 21 more: https://git.openjdk.org/jdk17u-dev/compare/01a62e385ef9852dac37acd3eb88a36665330275...master

Your commit was automatically rebased without conflicts.

@phohensee Pushed as commit 37b9867.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.